Move is_dot3 into details/pdu_helpers.h

include/tins/detail/pdu_helpers.h

@@ -56,6 +56,10 @@ PDU::PDUType ether_type_to_pdu_flag(Constants::Ethernet::e flag);
 Constants::IP::e pdu_flag_to_ip_type(PDU::PDUType flag);
 PDU::PDUType ip_type_to_pdu_flag(Constants::IP::e flag);
 
+inline bool is_dot3(const uint8_t* ptr, size_t sz) {
+    return (sz >= 13 && ptr[12] < 8);
+}
+
 } // Internals
 } // Tins
 

include/tins/internals.h

@@ -46,10 +46,6 @@ namespace Internals {
 // Compares sequence numbers as defined by RFC 1982.
 int seq_compare(uint32_t seq1, uint32_t seq2);
 
-inline bool is_dot3(const uint8_t* ptr, size_t sz) {
-    return (sz >= 13 && ptr[12] < 8);
-}
-
 } // namespace Internals
 } // namespace Tins
 /**

src/ethernetII.cpp

@@ -48,7 +48,6 @@
 #include "ipv6.h"
 #include "arp.h"
 #include "constants.h"
-#include "internals.h"
 #include "exceptions.h"
 #include "memory_helpers.h"
 #include "detail/pdu_helpers.h"

src/packet_sender.cpp

@@ -64,8 +64,8 @@
 #include "dot11/dot11_base.h"
 #include "radiotap.h"
 #include "ieee802_3.h"
-#include "internals.h"
 #include "cxxstd.h"
+#include "detail/pdu_helpers.h"
 #if TINS_IS_CXX11
     #include <chrono>
 #endif // TINS_IS_CXX11

src/ppi.cpp

@@ -37,9 +37,9 @@
 #include "loopback.h"
 #include "sll.h"
 #include "ppi.h"
-#include "internals.h"
 #include "exceptions.h"
 #include "memory_helpers.h"
+#include "detail/pdu_helpers.h"
 
 using Tins::Memory::InputMemoryStream;
 

src/sniffer.cpp

@@ -45,7 +45,7 @@
 #include "pktap.h"
 #include "sll.h"
 #include "ppi.h"
-#include "internals.h"
+#include "detail/pdu_helpers.h"
 
 using std::string;
 using std::runtime_error;