From f90e69045a5bb0b057e65d2026931733e911a297 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ciro=20Santilli=20=E5=85=AD=E5=9B=9B=E4=BA=8B=E4=BB=B6=20?=
 =?UTF-8?q?=E6=B3=95=E8=BD=AE=E5=8A=9F?= <ciro.santilli@gmail.com>
Date: Sun, 23 Sep 2018 16:46:11 +0100
Subject: [PATCH] release: github token from env var

---
 README.adoc | 6 ++++--
 common.py   | 5 +----
 release     | 1 -
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/README.adoc b/README.adoc
index fb5c427..42c7bc2 100644
--- a/README.adoc
+++ b/README.adoc
@@ -10959,6 +10959,7 @@ Create a release:
 ....
 git clone https://github.com/cirosantilli/linux-kernel-module-cheat linux-kernel-module-cheat-release
 cd linux-kernel-module-cheat-release
+# export LKMC_GITHUB_TOKEN=<your-token>
 ./release
 ....
 
@@ -11000,13 +11001,14 @@ which you can then upload somewhere.
 For example, you can create or update a GitHub release and upload automatically with:
 
 ....
-git push
-printf "$GITHUB_TOKEN" > "$(./getvar github_token_file)"
+# export LKMC_GITHUB_TOKEN=<your-token>
 ./release-upload
 ....
 
 Source: link:release-upload[]
 
+Create `LKMC_GITHUB_TOKEN` under: https://github.com/settings/tokens/new and save it to your `.bashrc`.
+
 TODO: generalize that so that people can upload to their forks.
 
 === Fairy tale
diff --git a/common.py b/common.py
index 13bc687..671bc9a 100644
--- a/common.py
+++ b/common.py
@@ -37,7 +37,6 @@ extract_vmlinux = os.path.join(linux_src_dir, 'scripts', 'extract-vmlinux')
 qemu_src_dir = os.path.join(submodules_dir, 'qemu')
 parsec_benchmark_src_dir = os.path.join(submodules_dir, 'parsec-benchmark')
 ccache_dir = os.path.join('/usr', 'lib', 'ccache')
-github_token_file = os.path.join(data_dir, 'github-token')
 arch_map = {
     'a': 'arm',
     'A': 'aarch64',
@@ -236,9 +235,7 @@ def github_make_request(
     headers = {'Accept': 'application/vnd.github.v3+json'}
     headers.update(extra_headers)
     if authenticate:
-        with open(this.github_token_file, 'r') as f:
-            token = f.read().rstrip()
-        headers['Authorization'] = 'token ' + token
+        headers['Authorization'] = 'token ' + os.environ['LKMC_GITHUB_TOKEN']
     if url_params is not None:
         path += '?' + urllib.parse.urlencode(url_params)
     request = urllib.request.Request(
diff --git a/release b/release
index 9d1c445..b1b035a 100755
--- a/release
+++ b/release
@@ -26,7 +26,6 @@ start_time = time.time()
 subprocess.check_call([os.path.join(common.root_dir, 'configure'), '--all'])
 subprocess.check_call([os.path.join(common.root_dir, 'build-all')])
 release_zip.main()
-subprocess.check_call(['git', 'tag', common.sha])
 subprocess.check_call(['git', 'push'])
 release_upload.main()
 end_time = time.time()