From c3a6c7e85ba0b95372d433349a7d404b36f2963c Mon Sep 17 00:00:00 2001
From: Ciro Santilli <cirosantilli@proton.me>
Date: Thu, 1 May 2025 12:28:16 +0100
Subject: [PATCH] Fix shift blowup without arguments

---
 rootfs_overlay/lkmc/fops.sh                 | 2 +-
 rootfs_overlay/lkmc/memfile.sh              | 2 +-
 rootfs_overlay/lkmc/scull.sh                | 2 +-
 rootfs_overlay/lkmc/seq_file.sh             | 2 +-
 rootfs_overlay/lkmc/seq_file_single_open.sh | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/rootfs_overlay/lkmc/fops.sh b/rootfs_overlay/lkmc/fops.sh
index 889f95b..f53c194 100755
--- a/rootfs_overlay/lkmc/fops.sh
+++ b/rootfs_overlay/lkmc/fops.sh
@@ -4,7 +4,7 @@ set -e
 # Setup
 f=/sys/kernel/debug/lkmc_fops
 mod="${1:-fops.ko}"
-shift
+[ $# -gt 1] && shift
 insmod "$mod" "$@"
 
 # read
diff --git a/rootfs_overlay/lkmc/memfile.sh b/rootfs_overlay/lkmc/memfile.sh
index 84f70f8..3fed942 100755
--- a/rootfs_overlay/lkmc/memfile.sh
+++ b/rootfs_overlay/lkmc/memfile.sh
@@ -9,7 +9,7 @@ odraw() (
 # Setup
 f=/sys/kernel/debug/lkmc_memfile
 mod="${1:-memfile.ko}"
-shift
+[ $# -gt 1] && shift
 insmod "$mod" "$@"
 
 # Starts off empty
diff --git a/rootfs_overlay/lkmc/scull.sh b/rootfs_overlay/lkmc/scull.sh
index 92097ca..9cd1263 100755
--- a/rootfs_overlay/lkmc/scull.sh
+++ b/rootfs_overlay/lkmc/scull.sh
@@ -4,7 +4,7 @@ set -eux
 name=scull
 
 mod="${1:-$name.ko}"
-shift
+[ $# -gt 1] && shift
 insmod "$mod" "$@"
 major="$(awk "\$2==\"$name\" {print \$1}" /proc/devices)"
 
diff --git a/rootfs_overlay/lkmc/seq_file.sh b/rootfs_overlay/lkmc/seq_file.sh
index 829fff7..259852c 100755
--- a/rootfs_overlay/lkmc/seq_file.sh
+++ b/rootfs_overlay/lkmc/seq_file.sh
@@ -2,7 +2,7 @@
 set -e
 f=/sys/kernel/debug/lkmc_seq_file
 mod="${1:-seq_file.ko}"
-shift
+[ $# -gt 1] && shift
 insmod "$mod" "$@"
 [ "$(cat "$f")" = "$(printf '0\n1\n2\n')" ]
 [ "$(cat "$f")" = "$(printf '0\n1\n2\n')" ]
diff --git a/rootfs_overlay/lkmc/seq_file_single_open.sh b/rootfs_overlay/lkmc/seq_file_single_open.sh
index d49afc7..ee8c552 100755
--- a/rootfs_overlay/lkmc/seq_file_single_open.sh
+++ b/rootfs_overlay/lkmc/seq_file_single_open.sh
@@ -2,7 +2,7 @@
 set -e
 f=/sys/kernel/debug/lkmc_seq_file_single_open
 mod="${1:-seq_file_single_open.ko}"
-shift
+[ $# -gt 1] && shift
 insmod "$mod" "$@"
 [ "$(cat "$f")" = "$(printf 'ab\ncd\n')" ]
 [ "$(dd if="$f" bs=1 count=3 skip=1)" = "$(printf "b\nc\n")" ]