3rd-party/libtins
1
0
Fork 0
mirror of https://github.com/mfontanini/libtins synced 2026-01-29 04:54:28 +01:00
Code Issues Releases Wiki Activity

Use InputMemoryStream when parsing PDU options and ICMP extensions

Browse Source
This commit is contained in:
Matias Fontanini
2017-06-08 20:15:08 -07:00
parent 550eea98b1
commit eed8229a04
2 changed files with 32 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/icmp_extension.cpp
View File

@@ -53,7 +53,6 @@ ICMPExtension::ICMPExtension(uint8_t ext_class, uint8_t ext_type)
}
ICMPExtension::ICMPExtension(const uint8_t* buffer, uint32_t total_sz) {
InputMemoryStream stream(buffer, total_sz);
@@ -138,10 +137,11 @@ bool ICMPExtensionsStructure::validate_extensions(const uint8_t* buffer, uint32_
if (total_sz < BASE_HEADER_SIZE) {
return false;
}
uint16_t checksum = *(const uint16_t*)(buffer + sizeof(uint16_t));
InputMemoryStream input(buffer, total_sz);
// The buffer is read only, so we can't set the initial checksum to 0. Therefore,
// we sum the first 2 bytes and then the payload
uint32_t actual_checksum = *(const uint16_t*)buffer;
uint32_t actual_checksum = input.read<uint16_t>();
uint16_t checksum = input.read<uint16_t>();
buffer += BASE_HEADER_SIZE;
total_sz -= BASE_HEADER_SIZE;
// Now do the checksum over the payload