3rd-party/libtins
1
0
Fork 0
mirror of https://github.com/mfontanini/libtins synced 2026-01-25 19:51:34 +01:00
Code Issues Releases Wiki Activity

Fix -Wextra compiler warnings. (#184)

Browse Source 
* Fix -Wextra compiler warnings.

Fix #183.

Signed-off-by: Kyle Fazzari <github@status.e4ward.com>

* Comment out unused parameters.

This is done everywhere possible instead of using Internals::unused().
Note that this involved moving some implementations into the
corresponding .cpp file.

Signed-off-by: Kyle Fazzari <github@status.e4ward.com>

* Fix warnings in tests as well.

Signed-off-by: Kyle Fazzari <github@status.e4ward.com>

* Leave IPv4Reassembler alone, it's growing.

Signed-off-by: Kyle Fazzari <github@status.e4ward.com>
This commit is contained in:
Kyle Fazzari
2017-01-25 13:26:11 -08:00
committed by Matias Fontanini
parent 94e5ac2109
commit a71a3d29ff
34 changed files with 80 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/pdu.cpp
View File

@@ -73,6 +73,9 @@ void PDU::copy_inner_pdu(const PDU& pdu) {
}
}
void PDU::prepare_for_serialize(const PDU* /*parent*/) {
}
uint32_t PDU::size() const {
uint32_t sz = header_size() + trailer_size();
const PDU* ptr(inner_pdu_);
@@ -91,6 +94,10 @@ PDU* PDU::recv_response(PacketSender &, const NetworkInterface &) {
return 0;
}
bool PDU::matches_response(const uint8_t* /*ptr*/, uint32_t /*total_sz*/) const {
return false;
}
void PDU::inner_pdu(PDU* next_pdu) {
delete inner_pdu_;
inner_pdu_ = next_pdu;