From 6b82e50c032b18f37f1cba531c3f8d4675c73d2e Mon Sep 17 00:00:00 2001 From: Jesus Llorente Date: Mon, 21 Dec 2015 17:56:18 +0200 Subject: [PATCH] Modified set_direction to return a bool --- include/tins/sniffer.h | 2 +- src/sniffer.cpp | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/tins/sniffer.h b/include/tins/sniffer.h index 0b552d7..3526ea5 100644 --- a/include/tins/sniffer.h +++ b/include/tins/sniffer.h @@ -218,7 +218,7 @@ namespace Tins { * This calls pcap_setdirection using the provided parameter. * \param d The direction for the sniffer. */ - int set_direction(pcap_direction_t d); + bool set_direction(pcap_direction_t d); /** * \brief Sets whether to extract RawPDUs or fully parsed packets. diff --git a/src/sniffer.cpp b/src/sniffer.cpp index 03fd3db..82adcea 100644 --- a/src/sniffer.cpp +++ b/src/sniffer.cpp @@ -224,8 +224,9 @@ void BaseSniffer::set_timeout(int ms) { pcap_set_timeout(handle, ms); } -int BaseSniffer::set_direction(pcap_direction_t d) { - return pcap_setdirection(handle, d); +bool BaseSniffer::set_direction(pcap_direction_t d) { + bool result = pcap_setdirection(handle, d) != -1; + return result; } // ****************************** Sniffer ****************************** @@ -453,7 +454,7 @@ void SnifferConfiguration::configure_sniffer_post_activation(Sniffer& sniffer) c throw std::runtime_error("Could not set the filter! "); } } - if (sniffer.set_direction(_direction) < 0) { + if (!sniffer.set_direction(_direction)) { throw std::runtime_error("Could not set the direction! "); } }