From 64725e2ed90b042219230b92866007b45a3d7e63 Mon Sep 17 00:00:00 2001 From: Huemac Date: Sun, 14 Aug 2016 22:29:53 +0300 Subject: [PATCH] Fix Cppcheck 1.75 warnings (#159) - The scope of the variable 'last_index' & 'index' could be reduced. - Prefer prefix ++/-- operators for non-primitive types. --- src/dns.cpp | 2 +- src/llc.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dns.cpp b/src/dns.cpp index 0b76139..1704d51 100644 --- a/src/dns.cpp +++ b/src/dns.cpp @@ -287,8 +287,8 @@ void DNS::add_additional(const resource& resource){ string DNS::encode_domain_name(const string& dn) { string output; - size_t last_index(0), index; if (!dn.empty()) { + size_t last_index(0), index; while ((index = dn.find('.', last_index+1)) != string::npos) { output.push_back(static_cast(index - last_index)); output.append(dn.begin() + last_index, dn.begin() + index); diff --git a/src/llc.cpp b/src/llc.cpp index bda085e..9408579 100644 --- a/src/llc.cpp +++ b/src/llc.cpp @@ -215,7 +215,7 @@ void LLC::write_serialization(uint8_t* buffer, uint32_t total_sz, const Tins::PD break; } - for (field_list::const_iterator it = information_fields_.begin(); it != information_fields_.end(); it++) { + for (field_list::const_iterator it = information_fields_.begin(); it != information_fields_.end(); ++it) { stream.write(it->begin(), it->end()); } }