3rd-party/libtins
1
0
Fork 0
mirror of https://github.com/mfontanini/libtins synced 2026-01-23 02:35:57 +01:00
Code Issues Releases Wiki Activity

Move packet into callback to avoid unnecessary clone, fix forward_iterator value type, and update comments

Browse Source
This commit is contained in:
Eric Cornelius
2015-02-06 10:24:43 -05:00
parent eb0b7c9091
commit 184328ea95
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/tins/internals.h
View File

@@ -223,7 +223,7 @@ struct accepts_type<T, P, enable_if_t<
// use enable_if to invoke the Packet& version of the sniff_loop handler if possible - otherwise fail to old behavior // use enable_if to invoke the Packet& version of the sniff_loop handler if possible - otherwise fail to old behavior
template <class Functor, class Packet> template <class Functor, class Packet>
bool invoke_loop_cb(Functor& f, Packet& p, typename std::enable_if<accepts_type<Functor, Packet>::value, bool>::type* = 0) { bool invoke_loop_cb(Functor& f, Packet& p, typename std::enable_if<accepts_type<Functor, Packet>::value, bool>::type* = 0) {
return f(p); return f(std::move(p));
} }
template <class Functor, class Packet> template <class Functor, class Packet>

5
include/tins/sniffer.h
View File

@@ -139,6 +139,9 @@ namespace Tins {
* \code * \code
* bool(PDU&); * bool(PDU&);
* bool(const PDU&); * bool(const PDU&);
* bool(const Packet&);
* bool(Packet&&);
* bool(Packet);
* \endcode * \endcode
* *
* This functor will be called using the each of the sniffed packets * This functor will be called using the each of the sniffed packets
@@ -391,7 +394,7 @@ namespace Tins {
/** /**
* \brief Iterates over packets sniffed by a BaseSniffer. * \brief Iterates over packets sniffed by a BaseSniffer.
*/ */
class SnifferIterator : public std::iterator<std::forward_iterator_tag, PDU> { class SnifferIterator : public std::iterator<std::forward_iterator_tag, Packet> {
public: public:
/** /**
* Constructs a SnifferIterator. * Constructs a SnifferIterator.