From 21f16930029a306e6e65a17642f787d09be8b638 Mon Sep 17 00:00:00 2001 From: Mike Long Date: Fri, 19 Aug 2022 16:21:02 +0200 Subject: [PATCH 1/4] Run tests in CI --- .github/workflows/verify_pr.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/verify_pr.yaml b/.github/workflows/verify_pr.yaml index 7e8c329..d04027e 100644 --- a/.github/workflows/verify_pr.yaml +++ b/.github/workflows/verify_pr.yaml @@ -13,9 +13,6 @@ jobs: os: [ubuntu-latest, windows-latest, macos-latest] steps: - uses: actions/checkout@v3 - - name: Configure CMake - run: cmake -B ${{github.workspace}}/build - name: Build - run: cmake --build ${{github.workspace}}/build - - name: Test - run: ctest --test-dir ${{github.workspace}} --output-on-failure + run: ./buildandtest + From 25d4c616beea8b07b3678fd306224d536cfcfce6 Mon Sep 17 00:00:00 2001 From: Mike Long Date: Fri, 19 Aug 2022 16:27:24 +0200 Subject: [PATCH 2/4] Build on push also --- .github/workflows/verify_pr.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/verify_pr.yaml b/.github/workflows/verify_pr.yaml index d04027e..aa96ce1 100644 --- a/.github/workflows/verify_pr.yaml +++ b/.github/workflows/verify_pr.yaml @@ -4,6 +4,8 @@ on: pull_request: branches: - master + push: + jobs: check-pr: From d4fed915a30c7d137bc99c926dccf1b2f5e11672 Mon Sep 17 00:00:00 2001 From: Mike Long Date: Fri, 19 Aug 2022 16:33:30 +0200 Subject: [PATCH 3/4] Add ninja to build envs --- .github/workflows/verify_pr.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/verify_pr.yaml b/.github/workflows/verify_pr.yaml index aa96ce1..b82940b 100644 --- a/.github/workflows/verify_pr.yaml +++ b/.github/workflows/verify_pr.yaml @@ -15,6 +15,7 @@ jobs: os: [ubuntu-latest, windows-latest, macos-latest] steps: - uses: actions/checkout@v3 + - uses: seanmiddleditch/gha-setup-ninja@master - name: Build run: ./buildandtest From 488442255c450de3244ed11fe3f3ce5c83a75658 Mon Sep 17 00:00:00 2001 From: Mike Long Date: Fri, 19 Aug 2022 16:37:21 +0200 Subject: [PATCH 4/4] Don't use shell script for CI runs, doesn't work on windows --- .github/workflows/verify_pr.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify_pr.yaml b/.github/workflows/verify_pr.yaml index b82940b..588afac 100644 --- a/.github/workflows/verify_pr.yaml +++ b/.github/workflows/verify_pr.yaml @@ -17,5 +17,9 @@ jobs: - uses: actions/checkout@v3 - uses: seanmiddleditch/gha-setup-ninja@master - name: Build - run: ./buildandtest + run: | + mkdir build + cmake -GNinja -B build + cmake --build build + ctest --test-dir build --output-on-failure